-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup warning #2
Cleanup warning #2
Conversation
4408a04
to
f26d8f4
Compare
7d2a8e5
to
554d2e7
Compare
@nvincent-vossloh Do you know why this code has been added: whereas this definition was already set here, from the device-tree: ? I wonder whether the best fix should be removing these lines instead: Any opinion? |
In earlier version of mcuboot/zephyr, the definition was not taken from the device tree and mcuboot did not supported the aligment of the stm32h7. The options provided by mcuboot config could not be set to the proper value and the config from zephyr was taken instead. You can have a look at the branch used in vog: https://github.com/SiemaApplications/mcuboot/blob/vog/zephyr_3.4/boot/zephyr/include/mcuboot_config/mcuboot_config.h |
And I have just found this: > @nvincent-vossloh Do you know why this code has been added: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L106-L110 (in 1fb66a1)
In earlier version of mcuboot/zephyr, the definition was not taken from the device tree and mcuboot did not supported the aligment of the stm32h7. The options provided by mcuboot config could not be set to the proper value and the config from zephyr was taken instead. We update to newer version of mcuboot/zephyr the upstream code then supported the aligment of the h7 but the custom fix was not removed. You can have a look at the branch used in vog/zephyr_3.2: 9bbaf5a So, I will cherry-pick your fix. |
The max alignement for flash write is now fetched from device tree, there is no need for that kconfig entry anymore. Fixes 1fb66a1 Signed-off-by: Nicolas VINCENT <[email protected]>
…DOWNGRADE_ALLOWED is set Avoid compilation warning about unused function. Signed-off-by: Samuel MARTIN <[email protected]>
Our CI environment does not support Mynewt targets. Signed-off-by: Samuel MARTIN <[email protected]>
554d2e7
to
09353ab
Compare
82c5721
into
SiemaApplications-attic:dsp3/zephyr_3.2
This short series cleans up warning occurring at build for dsp3 bootloader and application.