Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup warning #2

Conversation

smartin-vossloh
Copy link

@smartin-vossloh smartin-vossloh commented Jan 12, 2024

This short series cleans up warning occurring at build for dsp3 bootloader and application.

@nvincent-vossloh
Copy link

@nvincent-vossloh Do you know why this code has been added: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L106-L110 (in 1fb66a1)

whereas this definition was already set here, from the device-tree: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L246-L252 (in 66cdd46)

?

I wonder whether the best fix should be removing these lines instead: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L106-L110

Any opinion?

In earlier version of mcuboot/zephyr, the definition was not taken from the device tree and mcuboot did not supported the aligment of the stm32h7. The options provided by mcuboot config could not be set to the proper value and the config from zephyr was taken instead.
We update to newer version of mcuboot/zephyr the upstream code then supported the aligment of the h7 but the custom fix was not removed.

You can have a look at the branch used in vog: https://github.com/SiemaApplications/mcuboot/blob/vog/zephyr_3.4/boot/zephyr/include/mcuboot_config/mcuboot_config.h
Only the value from the device tree seems to be used.

@smartin-vossloh
Copy link
Author

@nvincent-vossloh Do you know why this code has been added: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L106-L110 (in 1fb66a1)
whereas this definition was already set here, from the device-tree: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L246-L252 (in 66cdd46)
?
I wonder whether the best fix should be removing these lines instead: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L106-L110
Any opinion?

In earlier version of mcuboot/zephyr, the definition was not taken from the device tree and mcuboot did not supported the aligment of the stm32h7. The options provided by mcuboot config could not be set to the proper value and the config from zephyr was taken instead. We update to newer version of mcuboot/zephyr the upstream code then supported the aligment of the h7 but the custom fix was not removed.

You can have a look at the branch used in vog: https://github.com/SiemaApplications/mcuboot/blob/vog/zephyr_3.4/boot/zephyr/include/mcuboot_config/mcuboot_config.h Only the value from the device tree seems to be used.

And I have just found this: > @nvincent-vossloh Do you know why this code has been added: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L106-L110 (in 1fb66a1)

whereas this definition was already set here, from the device-tree: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L246-L252 (in 66cdd46)
?
I wonder whether the best fix should be removing these lines instead: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L106-L110
Any opinion?

In earlier version of mcuboot/zephyr, the definition was not taken from the device tree and mcuboot did not supported the aligment of the stm32h7. The options provided by mcuboot config could not be set to the proper value and the config from zephyr was taken instead. We update to newer version of mcuboot/zephyr the upstream code then supported the aligment of the h7 but the custom fix was not removed.

You can have a look at the branch used in vog/zephyr_3.2: 9bbaf5a

So, I will cherry-pick your fix.

nvincent-vossloh and others added 3 commits January 15, 2024 11:39
The max alignement for flash write is now fetched from device tree,
there is no need for that kconfig entry anymore.

Fixes 1fb66a1

Signed-off-by: Nicolas VINCENT <[email protected]>
…DOWNGRADE_ALLOWED is set

Avoid compilation warning about unused function.

Signed-off-by: Samuel MARTIN <[email protected]>
Our CI environment does not support Mynewt targets.

Signed-off-by: Samuel MARTIN <[email protected]>
@smartin-vossloh smartin-vossloh merged commit 82c5721 into SiemaApplications-attic:dsp3/zephyr_3.2 Jan 16, 2024
41 checks passed
@smartin-vossloh smartin-vossloh deleted the sma/cleanup-warning branch January 16, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants